Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add stacks multisig support, closes #3889 #4276

Merged
merged 1 commit into from
Oct 10, 2023
Merged

feat: add stacks multisig support, closes #3889 #4276

merged 1 commit into from
Oct 10, 2023

Conversation

kyranjamie
Copy link
Collaborator

@kyranjamie kyranjamie commented Sep 27, 2023 •
edited by github-actions bot
Loading

Try out this version of Leather — download extension builds.

Copy of @fess-v's PR

@kyranjamie kyranjamie mentioned this pull request Sep 27, 2023
Closed
@kyranjamie kyranjamie force-pushed the feature/3889_sign_stacks_transaction_rpc branch from b2a2821 to c25d522 Compare September 27, 2023 16:48
@fess-v
Copy link
Contributor

fess-v commented Sep 27, 2023

@kyranjamie fixed it in my previous PR branch, seems like lint:fix or lint:prettier:fix do some changes that break types logic :(
like it was in such files as bns.utils.ts

@kyranjamie kyranjamie force-pushed the feature/3889_sign_stacks_transaction_rpc branch from c25d522 to d05300c Compare October 3, 2023 13:02
@markmhendrickson
Copy link
Collaborator

markmhendrickson commented Oct 6, 2023 •
edited
Loading

@kyranjamie is this ready to release assuming we merge in the latest from the previous branch?

@kyranjamie kyranjamie force-pushed the feature/3889_sign_stacks_transaction_rpc branch from d05300c to f3d0ecb Compare October 9, 2023 11:19
@kyranjamie kyranjamie force-pushed the feature/3889_sign_stacks_transaction_rpc branch from f3d0ecb to cf58f21 Compare October 9, 2023 12:03
@kyranjamie kyranjamie requested review from fbwoolf, alter-eggo and pete-watters and removed request for fbwoolf October 9, 2023 12:04
fbwoolf
fbwoolf approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@fbwoolf fbwoolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, should the promise warnings be addressed here?

@kyranjamie
Copy link
Collaborator Author

Lgtm, should the promise warnings be addressed here?

Don't think these were introduced here so will just merge

@kyranjamie kyranjamie added this pull request to the merge queue Oct 10, 2023
Merged via the queue into dev with commit 9dabfc2 Oct 10, 2023
@kyranjamie kyranjamie deleted the feature/3889_sign_stacks_transaction_rpc branch October 10, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alter-eggo alter-eggo alter-eggo approved these changes

@fbwoolf fbwoolf fbwoolf approved these changes

@pete-watters pete-watters pete-watters approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kyranjamie @fess-v @markmhendrickson @pete-watters @fbwoolf @alter-eggo